serhiy-bzhezytskyy commented on code in PR #4762:
URL: https://github.com/apache/solr/pull/4762#discussion_r3820872721
##########
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/sql/JdbcTest.java:
##########
@@ -646,7 +646,7 @@ private void testJDBCMethods(
}
CloudSolrClient solrClient = cluster.getSolrClient();
- solrClient.connect();
+ solrClient.getClusterStateProvider().getLiveNodes(); // force the
connection now
Review Comment:
Confirmed -- removed. `ZkStateReader.from(solrClient)` on the very next line
forces the same lazy connection, same as the 4 spots you flagged earlier.
AI-assisted (Claude Sonnet 5)
##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -356,7 +356,7 @@ protected void initCloud() {
assert (cloudInit == false);
cloudInit = true;
cloudClient = createCloudClient(DEFAULT_COLLECTION);
- cloudClient.connect();
+ cloudClient.getClusterStateProvider().getLiveNodes(); // force the
connection now
Review Comment:
Right -- `ZkStateReader.from(cloudClient)` two lines below does exactly
that. Removed.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
