serhiy-bzhezytskyy commented on code in PR #4762:
URL: https://github.com/apache/solr/pull/4762#discussion_r3820255542
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/TestCollectionAPI.java:
##########
@@ -687,7 +687,7 @@ private void clusterStatusWithCollectionAndShardJSON()
throws IOException, SolrS
private void clusterStatusRolesTest() throws Exception {
try (CloudSolrClient client = createCloudClient(null)) {
- client.connect();
+ client.getClusterStateProvider().getLiveNodes(); // force the connection
now
Review Comment:
Confirmed -- `CloudSolrClient.sendRequest()` unconditionally calls
`provider.getLiveNodes()` for a request without a collection param, which is
what `client.request(...)` sends a few lines later here (and
`getClusterState()` in the other spot delegates to the same lazy-init path). So
the forcing call was dead weight, not a migration bug -- removed in all 4 spots
you flagged, both test classes re-run green.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
