serhiy-bzhezytskyy commented on code in PR #4762:
URL: https://github.com/apache/solr/pull/4762#discussion_r3820611807
##########
solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java:
##########
@@ -170,11 +168,9 @@ private void assertSameTraceId(LogListener reqLog, String
traceId) {
}
private CloudSolrClient newCloudSolrClient() {
- var builder =
- new CloudSolrClient.Builder(
- List.of(cluster.getZkServer().getZkAddress()), Optional.empty());
+ var builder = new
CloudSolrClient.Builder(cluster.getZkServer().getZkAddress());
Review Comment:
Done as a separate commit -- added
`MiniSolrCloudCluster.getSolrClientBuilder()` and migrated all 7 sites
hand-rolling `new
CloudSolrClient.Builder(cluster.getZkServer().getZkAddress())`. One more site,
`ForceLeaderTest`, uses the older `AbstractFullDistribZkTestBase` framework
with its own `zkServer` field, not `MiniSolrCloudCluster` -- left that one out.
AI-assisted (Claude Sonnet 5)
##########
solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java:
##########
@@ -170,11 +168,9 @@ private void assertSameTraceId(LogListener reqLog, String
traceId) {
}
private CloudSolrClient newCloudSolrClient() {
- var builder =
Review Comment:
Yes, `builder` is a `CloudSolrClient.Builder` -- unambiguous at the source
level. The PR description was describing a build-time artifact: reintroduced
both removed calls together and confirmed javac reports only the constructor
error, silently swallowing the separate `client.connect()` removal error on the
next line (its type can't resolve once `builder`'s initializer fails). Not a
type-identity issue, just an ambiguous sentence on my part -- sorry.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
