serhiy-bzhezytskyy opened a new pull request, #4764:
URL: https://github.com/apache/solr/pull/4764
Removes `CoreContainer.getCores()`/`SolrCores.getCores()` — 26 sites. Not a
rename: the removed methods handed out unreserved cores; the replacement
(`getLoadedCoreNames()` + `getCore(String)`) reserves, so every site now
acquires and releases.
Where to look: two shutdown paths (`cancelCoreRecoveries`,
`pauseUpdatesAndAwaitInflightRequests`) can't use `getCore` — it can *load* a
core, wrong during shutdown — so they use `getCoreFromAnyList(name, true)`
instead, which never loads. `TestTlogReplica`'s two helpers deliberately return
already-released cores, matching the old contract, to avoid an 11-site refactor
out of scope here.
Also fixed a dangling `{@link #getCores()}` — only `ecjLintMain` catches
that, not the compiler or `renderJavadoc`.
93 tests / 15 classes / 0 failures. Simulated merge order against SOLR-18382
(#4760) and SOLR-18380 (#4762), which also touch shared files — applies cleanly
either way.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
