serhiy-bzhezytskyy commented on code in PR #4764:
URL: https://github.com/apache/solr/pull/4764#discussion_r3819862854
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1382,13 +1382,12 @@ public void shutdown() {
}
public void cancelCoreRecoveries() {
-
- List<SolrCore> cores = solrCores.getCores();
Review Comment:
Fair -- checked, and `SolrCores` is package-private and only ever referenced
from `CoreContainer`, so the deprecation was arguably unnecessary ceremony from
the start. Not making a case for the original deprecation though -- the ticket
scope was to remove both `getCores()` methods together, so that's what this PR
does.
AI-assisted (Claude Sonnet 5)
##########
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##########
@@ -142,20 +142,6 @@ public SolrCore putCore(CoreDescriptor cd, SolrCore core) {
}
}
- /**
- * @return A list of "permanent" cores, i.e. cores that may not be swapped
out and are currently
- * loaded.
- * <p>A core may be non-transient but still lazily loaded. If it is
"permanent" and lazy-load
- * _and_ not yet loaded it will _not_ be returned by this call.
- * <p>This list is a new copy, it can be modified by the caller (e.g. it
can be sorted).
- */
- @Deprecated
Review Comment:
Same as the `CoreContainer.java:1386` thread -- fair point, no argument.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
