dsmiley commented on code in PR #4764:
URL: https://github.com/apache/solr/pull/4764#discussion_r3830841599
##########
solr/core/src/java/org/apache/solr/pkg/SolrPackageLoader.java:
##########
@@ -106,8 +106,11 @@ public void refreshPackageConf() {
}
}
}
- for (SolrCore core : coreContainer.getCores()) {
- core.getPackageListeners().packagesUpdated(updated);
+ for (String coreName : coreContainer.getLoadedCoreNames()) {
Review Comment:
Shouldn't this use the new method?
##########
solr/core/src/java/org/apache/solr/handler/admin/api/NodeHealth.java:
##########
@@ -151,13 +151,16 @@ private void healthCheckStandaloneMode(NodeHealthResponse
response, Integer maxG
return;
}
- for (SolrCore core : coreContainer.getCores()) {
- ReplicationHandler replicationHandler =
- (ReplicationHandler)
core.getRequestHandler(ReplicationHandler.PATH);
- if (replicationHandler.isFollower()) {
- boolean isCoreInSync =
- isWithinGenerationLag(core, replicationHandler,
maxGenerationLag, laggingCoresInfo);
- allCoresAreInSync &= isCoreInSync;
+ for (String coreName : coreContainer.getLoadedCoreNames()) {
Review Comment:
Shouldn't this use the new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
