serhiy-bzhezytskyy commented on PR #4764: URL: https://github.com/apache/solr/pull/4764#issuecomment-5346814338
@dsmiley you deprecated `getCores()` on both `CoreContainer` and `SolrCores` back in 2023. Worth flagging directly: the javadoc's own suggested replacement (`getCore(name)`) turns out to load a core if it isn't already loaded -- wrong on 2 shutdown paths, where that's exactly what must not happen. Used `getCoreFromAnyList(name, true)` instead. Given it's your deprecation and the fix touches a subtlety in the reference-counting contract, a review here would carry real weight. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
