serhiy-bzhezytskyy commented on PR #4764: URL: https://github.com/apache/solr/pull/4764#issuecomment-5377839252
Fair — pushed a follow-up commit migrating `SolrPackageLoader` and `NodeHealth` too. Both had the same footgun this ticket already fixed elsewhere: `getCore(coreName)` after a `getLoadedCoreNames()` snapshot reloads the core if it was unloaded in between, which is wrong for a package-update notification or a health check. `forEachLoadedCore`'s `getCoreFromAnyList(name, true)` never does that. Agree the new method should be the default everywhere this pattern shows up -- these were the only other two call sites left in this PR's diff. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
