dsmiley commented on code in PR #4761:
URL: https://github.com/apache/solr/pull/4761#discussion_r3853295410
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -1282,6 +1280,11 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest
sreq) {
}
}
+ protected static void updateResponseHeader(NamedList<Object> header, String
key, Object value) {
+ header.remove(key);
+ header.add(key, value);
+ }
+
Review Comment:
Thank you :-)
In the mean time: Couldn't we update our mocks to return a SimpleOrderedMap?
Just because the "documented contract" is a NamedList, doesn't mean Solr truly
needs to support a plain NamedList from these methods on SolrQueryResponse.
SQR is the base implementation; subclasses add to the instances returned by the
base; don't replace / override (I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
