serhiy-bzhezytskyy commented on code in PR #4761:
URL: https://github.com/apache/solr/pull/4761#discussion_r3853900043
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -1282,6 +1280,11 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest
sreq) {
}
}
+ protected static void updateResponseHeader(NamedList<Object> header, String
key, Object value) {
+ header.remove(key);
+ header.add(key, value);
+ }
+
Review Comment:
Done -- fixed `MockResponseBuilder` to return a real `SimpleOrderedMap`,
restored the cast+`put()` (verified: `QueryComponentPartialResultsTest` passes
without needing the return-type change from #4809 at all). That PR can stand on
its own merits now rather than being a blocker here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
