[
https://issues.apache.org/jira/browse/SOLR-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132574#comment-18132574
]
Nick Shanin commented on SOLR-17861:
------------------------------------
Status note on the license scope for the new UI module.
I built the first slice of what this ticket asks for: a checksum check over the
desktop JVM classpath on linux_x64, wired into {{./gradlew -p ui check}}. It is
on a
[branch|https://github.com/nick-boss-tech/solr/tree/solr-17861-ui-license-check],
and the
[diff|https://github.com/apache/solr/compare/main...nick-boss-tech:solr-17861-ui-license-check]
is the {{desktopApp}} build wiring plus the per-jar checksum files under
{{ui/licenses}}. That is the checksum side of what the ticket asks
{{updateLicenses}} and the license checks to cover for the KMP module.
For the other half, per-jar LICENSE and NOTICE presence: the repo rule
({{gradle/validation/jar-checks.gradle}}) requires those files for jars shipped
in the binary distribution, and the {{ui}} project does not ship jars in the
distribution. That question belongs with the desktop distribution work in
SOLR-17970, where what ships gets decided.
[~malliaridis] shall I open the checksum slice as a PR for this ticket, and are
you content for the LICENSE and NOTICE presence question to move to SOLR-17970?
🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
> Extend updateLicenses task to cover KMP module
> ----------------------------------------------
>
> Key: SOLR-17861
> URL: https://issues.apache.org/jira/browse/SOLR-17861
> Project: Solr
> Issue Type: Improvement
> Components: Admin UI, Gradle, scripts and tools
> Reporter: Christos Malliaridis
> Priority: Minor
> Labels: gradle, new-ui, ui
>
> With the Admin UI module we have intrdouced a Kotlin multiplatform (KMP)
> module that is no longer a simple java-based gradle module. This means that
> some of our tasks, like {{updateLicenses}} won't cover it and ignore it
> completely.
> h2. Task
> Update the {{updateLicenses}} gradle task to cover the multiplatform
> dependencies included in the Admin UI module.
> h2. Acceptance Criteria
> - The {{updateLicenses}} task successfully identifies missing LICENSE and
> NOTICE Files from KMP modules
> - The LICENSE and NOTICE files cover all platforms
> - The {{updateLicenses}} task is environement-independent (see additional
> information below)
> h2. Additional Information
> During the introduction of the UI module, when we tried to configure the
> tasks for the lockfile generation, we noticed that locks were generated
> differently based on the operating system that was executing the lockfile
> (e.g. windows was generating other lockfiles than linux systems). One of the
> challenges is therefore to find a way to unify the license and notice file
> checks so that they take all target configurations (wasmJS and JVM) into
> account.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
