[
https://issues.apache.org/jira/browse/SOLR-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134856#comment-18134856
]
Christos Malliaridis commented on SOLR-17861:
---------------------------------------------
I am not sure if adding the dependency of each OS to the dependency tree is
solving the problem the way it should be solved. I will have to review the
generated build, and also check the implementation for the other dependencies.
If we have to add every dependency 4-5 times just to cover the checksum
generation, then I believe we need a different approach. Feel free to create a
PR for this, so we can continue discussion on the code itself.
> Extend updateLicenses task to cover KMP module
> ----------------------------------------------
>
> Key: SOLR-17861
> URL: https://issues.apache.org/jira/browse/SOLR-17861
> Project: Solr
> Issue Type: Improvement
> Components: Admin UI, Gradle, scripts and tools
> Reporter: Christos Malliaridis
> Priority: Minor
> Labels: gradle, new-ui, ui
>
> With the Admin UI module we have intrdouced a Kotlin multiplatform (KMP)
> module that is no longer a simple java-based gradle module. This means that
> some of our tasks, like {{updateLicenses}} won't cover it and ignore it
> completely.
> h2. Task
> Update the {{updateLicenses}} gradle task to cover the multiplatform
> dependencies included in the Admin UI module.
> h2. Acceptance Criteria
> - The {{updateLicenses}} task successfully identifies missing LICENSE and
> NOTICE Files from KMP modules
> - The LICENSE and NOTICE files cover all platforms
> - The {{updateLicenses}} task is environement-independent (see additional
> information below)
> h2. Additional Information
> During the introduction of the UI module, when we tried to configure the
> tasks for the lockfile generation, we noticed that locks were generated
> differently based on the operating system that was executing the lockfile
> (e.g. windows was generating other lockfiles than linux systems). One of the
> challenges is therefore to find a way to unify the license and notice file
> checks so that they take all target configurations (wasmJS and JVM) into
> account.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
