[
https://issues.apache.org/jira/browse/SOLR-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133180#comment-18133180
]
Nick Shanin commented on SOLR-17861:
------------------------------------
[~malliaridis], an update on the operating-system coverage you raised.
The branch
[solr-17861-ui-license-check|https://github.com/nick-boss-tech/solr/tree/solr-17861-ui-license-check]
now carries checksums for all five desktop runtime classifiers, and the checks
have run on two host operating systems at the same commit,
{{b0b0b39f7e62fa0247e133d4019bbb23f9def446}}.
On 2026-10-27, I ran the checksum checks on Windows 11 x64 with Gradle 9.7.0
and Eclipse Adoptium JDK 21.0.11 at commit
{{b0b0b39f7e62fa0247e133d4019bbb23f9def446}}. First, {{.\gradlew.bat -p ui
:desktopApp:validateLicenses --console=plain}} passed against the committed
files before regeneration. I then ran {{.\gradlew.bat -p ui
:desktopApp:updateLicenses :desktopApp:validateLicenses
:desktopApp:spotlessCheck :desktopApp:check --console=plain}}; all tasks
passed. The generated set contains 105 checksum files, including Skiko runtime
checksums for Linux x64 and ARM64, macOS x64 and ARM64, and Windows x64.
Regeneration left the checksum contents unchanged. {{:desktopApp:test}} was
{{NO-SOURCE}}.
On Linux x86_64 with JDK 21 and Gradle 9.7.0, at the same commit, {{./gradlew
-p ui :desktopApp:validateLicenses --console=plain}} passed against the
committed files before regeneration, and the full run ({{updateLicenses}},
{{validateLicenses}}, {{spotlessCheck}}, {{check}}) passed, with regeneration
leaving the worktree unchanged. The same 105 checksum files, including all five
Skiko runtime classifiers, are present, and {{:desktopApp:test}} was
{{NO-SOURCE}} there as well.
I do not have access to a macOS host, so the checks cannot be executed on macOS
from my side. The macOS checksums are generated and validated as part of the
set on both hosts above. Do the Windows and Linux host results, with all five
target classifiers checked, address the concern, or would a macOS host run
still be needed, in which case it would have to come from someone with a Mac?
🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
> Extend updateLicenses task to cover KMP module
> ----------------------------------------------
>
> Key: SOLR-17861
> URL: https://issues.apache.org/jira/browse/SOLR-17861
> Project: Solr
> Issue Type: Improvement
> Components: Admin UI, Gradle, scripts and tools
> Reporter: Christos Malliaridis
> Priority: Minor
> Labels: gradle, new-ui, ui
>
> With the Admin UI module we have intrdouced a Kotlin multiplatform (KMP)
> module that is no longer a simple java-based gradle module. This means that
> some of our tasks, like {{updateLicenses}} won't cover it and ignore it
> completely.
> h2. Task
> Update the {{updateLicenses}} gradle task to cover the multiplatform
> dependencies included in the Admin UI module.
> h2. Acceptance Criteria
> - The {{updateLicenses}} task successfully identifies missing LICENSE and
> NOTICE Files from KMP modules
> - The LICENSE and NOTICE files cover all platforms
> - The {{updateLicenses}} task is environement-independent (see additional
> information below)
> h2. Additional Information
> During the introduction of the UI module, when we tried to configure the
> tasks for the lockfile generation, we noticed that locks were generated
> differently based on the operating system that was executing the lockfile
> (e.g. windows was generating other lockfiles than linux systems). One of the
> challenges is therefore to find a way to unify the license and notice file
> checks so that they take all target configurations (wasmJS and JVM) into
> account.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
