[
https://issues.apache.org/jira/browse/SOLR-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133004#comment-18133004
]
Christos Malliaridis commented on SOLR-17861:
---------------------------------------------
The reason this ticket exists and has not been solved with our existing code
from before is because the different operating systems load different
dependencies, and there is no solution found yet that can load from all three
operating systems the dependencies and write down the checksums. The whole
reason why the checksums exist is to validate against the currently loaded
dependencies to make sure there is no diff. If someone on Windows or Mac would
run this, they would need the OS-specific dependencies and checksums.
Your solution so far addresses only Unix. Is there a reason why you picked Unix
only? One could argument that one thing is better than nothing, but I would
have to test this on Windows and Mac to make sure that no checks fail just
because I am on a different OS. So your branch seems to implement only half of
the expected outcome, at least for how I feel.
> Extend updateLicenses task to cover KMP module
> ----------------------------------------------
>
> Key: SOLR-17861
> URL: https://issues.apache.org/jira/browse/SOLR-17861
> Project: Solr
> Issue Type: Improvement
> Components: Admin UI, Gradle, scripts and tools
> Reporter: Christos Malliaridis
> Priority: Minor
> Labels: gradle, new-ui, ui
>
> With the Admin UI module we have intrdouced a Kotlin multiplatform (KMP)
> module that is no longer a simple java-based gradle module. This means that
> some of our tasks, like {{updateLicenses}} won't cover it and ignore it
> completely.
> h2. Task
> Update the {{updateLicenses}} gradle task to cover the multiplatform
> dependencies included in the Admin UI module.
> h2. Acceptance Criteria
> - The {{updateLicenses}} task successfully identifies missing LICENSE and
> NOTICE Files from KMP modules
> - The LICENSE and NOTICE files cover all platforms
> - The {{updateLicenses}} task is environement-independent (see additional
> information below)
> h2. Additional Information
> During the introduction of the UI module, when we tried to configure the
> tasks for the lockfile generation, we noticed that locks were generated
> differently based on the operating system that was executing the lockfile
> (e.g. windows was generating other lockfiles than linux systems). One of the
> challenges is therefore to find a way to unify the license and notice file
> checks so that they take all target configurations (wasmJS and JVM) into
> account.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
