epugh commented on PR #5313: URL: https://github.com/apache/solr/pull/5313#issuecomment-6855426464
@dsmiley so I think "solr.cloud.wait.for.zk.seconds" was really only ever meant for facilitating the `ZkFailoverTest` scnearios and I was able to eliminate it from the test and just use existing regular `solr.zookeeper.client.timeout` property in the commit #f7304f7db6a0abf5ab2940458e3a1d2cd7fd6eed I am curious if you would agree that instead of documenting with changelog, deprecation warning, and docs that `solr.cloud.wait.for.zk.seconds` is going away, it could just be deleted as a piece of internal to Solr testing infrastructure that no longer is needed? that would simplify this pr, we could skip the upgrade notes, simplify one of the hcanges to `solr.in.cmd`/`solr.in.sh`, and I would remove any mention from `solr-properties.adoc`..... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
