github-actions[bot] commented on PR #5334: URL: https://github.com/apache/solr/pull/5334#issuecomment-6862105463
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— differs from the entry** (suggest type: changed; PR has type: fixed): The change modifies the behavior of the existing getImmutableCopy() method on SimpleOrderedMap so that it now returns a SimpleOrderedMap instead of degrading to a NamedList, which is a non-opt-in improvement to existing behavior. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- SimpleOrderedMap is an internal utility class in solrj, not a user-facing API, request parameter, or configuration setting documented in the Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is source-compatible (narrowing the return type) and only makes the returned object a more specific subtype, so it does not break existing user code or alter behavior in a way that requires user action on upgrade. --> - ✅ Tests: included <!-- The PR changes production logic in SimpleOrderedMap.getImmutableCopy() to preserve the subclass type, which is non-trivial behavior that warrants a test to verify the copy is a SimpleOrderedMap and remains immutable. --> <!-- Assessed commit c64ef9dcc6360bd6bd39cb129d1b9f3e94e8ce67 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
