isaric commented on PR #5334: URL: https://github.com/apache/solr/pull/5334#issuecomment-6921643176
Done in 91acc6b, with one deviation: NamedList allows null names and values (the existing tests put both), and List.of/List.copyOf throw NPE on nulls, so both methods now wrap a single array copy (`Collections.unmodifiableList(Arrays.asList(nvPairs.toArray()))`) via a shared helper, which drops the clone() and the second list. Added a null-preserving test to each class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
