nick-boss-tech commented on PR #5334:
URL: https://github.com/apache/solr/pull/5334#issuecomment-6868285577

   🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)*
   
   Hi @isaric, I found a Java serialization compatibility change in this PR. 
Adding `getImmutableCopy()` changes the generated `serialVersionUID` of 
`SimpleOrderedMap`. A stream written at the PR head fails to deserialize on the 
pre-PR base with `InvalidClassException`.
   
   I prepared a 
[follow-up](https://github.com/nick-boss-tech/solr/compare/c64ef9dcc6360bd6bd39cb129d1b9f3e94e8ce67...c9896f0e5b026545ebefcb6f225da67550acdd21)
 that preserves the pre-PR identifier and adds tests for the identifier and 
mutations through the Map view.
   
   <details>
   <summary>Linux verification at 
c9896f0e5b026545ebefcb6f225da67550acdd21</summary>
   
   - `SimpleOrderedMapTest`: 20 passed. `NamedListTest`: 5 passed. No skips. 
Seed: `5334C0DE`.
   - Tidy and `check -x test` passed using the host Gradle 9.7.0 wrapper and 
JDK 21.
   - Serialization passed in both directions between the pre-PR base and the 
follow-up, including null keys, null values, and nested lists and maps.
   - The new UID assertion failed on the PR head with the changed identifier. 
The Map-view assertions passed there.
   
   This checks compatibility with the immediate pre-PR base. It does not 
establish compatibility with earlier releases.
   
   </details>
   
   The follow-up is a fast-forward from the current PR head:
   
   ```sh
   git switch SOLR-18631-som-immutable-copy
   git fetch https://github.com/nick-boss-tech/solr.git 
pr-5334-compatibility-20261113
   git merge --ff-only c9896f0e5b026545ebefcb6f225da67550acdd21
   ```
   
   Would you like to include this compatibility fix in the PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to