isaric commented on code in PR #5334:
URL: https://github.com/apache/solr/pull/5334#discussion_r4588115385
##########
solr/solrj/src/test/org/apache/solr/common/util/SimpleOrderedMapTest.java:
##########
@@ -75,6 +76,13 @@ public void testJavaSerializationRoundTrip() throws
Exception {
assertEquals(original, deserialized);
}
+ @Test
+ public void testSerialVersionUID() {
+ assertEquals(
+ -8705511030983987520L,
Review Comment:
Yes. -8705511030983987520 is the identifier computed on main before this PR
(ObjectStreamClass.lookup on an untouched checkout gives the same value);
adding getImmutableCopy() changed the derived one, which the test caught on the
PR head before the constant was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]