epugh commented on code in PR #5333:
URL: https://github.com/apache/solr/pull/5333#discussion_r4580325319
##########
solr/core/src/java/org/apache/solr/core/NodeRoles.java:
##########
@@ -57,6 +58,10 @@ public NodeRoles(String rolesString) {
roles.put(r, r.modeWhenRoleIsAbsent());
}
}
+ // Overrides any parsed zookeeper mode with reality; invalid modes are
still rejected above.
+ roles.put(
+ Role.ZOOKEEPER,
Review Comment:
like, basically we don't allow you to pass this in at all? I can see how
that might be the right appraoch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]