janhoy commented on code in PR #5333:
URL: https://github.com/apache/solr/pull/5333#discussion_r4642550488
##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -40,6 +40,48 @@ teardown() {
refute_output --partial 'forcefully killing'
}
+@test "SOLR-11966 stop ZooKeeper hosts after other SolrCloud nodes" {
Review Comment:
🤖 This PR adds two tests to `test_start_solr.bats`: *SOLR-11966 stop
ZooKeeper hosts after other SolrCloud nodes* and *embedded ZooKeeper preserves
custom node roles*. BATS is going away: CATS (SOLR-18642, #5323) has replaced
it on `main`, and SOLR-18645 (#5369) removes the `.bats` files. Please port
both to `StartSolrTest` in `solr/packaging/src/test/org/apache/solr/shell/`.
The CATS HTTP and wait helpers replace the `curl`/`wait_for` polling. See
[dev-docs/cats.adoc](https://github.com/apache/solr/blob/main/dev-docs/cats.adoc)
for porting help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]