epugh commented on code in PR #5333:
URL: https://github.com/apache/solr/pull/5333#discussion_r4580329539


##########
solr/solr-ref-guide/modules/deployment-guide/pages/node-roles.adoc:
##########
@@ -69,6 +72,18 @@ A node with this role (in mode "on") can host shards and 
replicas for collection
 === `overseer` role
 A node with this role can perform duties of an overseer node (unless mode is 
`disallowed`). When one or more nodes have the overseer role in `preferred` 
mode, the overseer leader will be elected from one of these nodes. In case no 
node is designated as a preferred overseer or no such node is live, the 
overseer leader will be elected from one of the nodes that have the overseer 
role in `allowed` mode. If all nodes that are designated with overseer role 
(allowed or preferred) are down, the cluster will be left without an overseer.
 
+=== `zookeeper` role
+
+The `zookeeper:on` role identifies a Solr node that hosts an embedded 
ZooKeeper server.
+Solr derives this role from `solr.zookeeper.server.enabled`, preserving the 
node's other roles.
+If no roles were configured, the node retains the defaults 
`data:on,overseer:allowed` alongside `zookeeper:on`.
+
+On Unix/macOS only, `bin/solr stop --all` stops nodes hosting embedded 
ZooKeeper last.

Review Comment:
   I wanted to be really clear..  partly because I wasn't sure that `solr.cmd` 
WOULD catch up..  in fact, I worried this wouldn't move forward if it was 
unix/macos only.    I'm hoping you are pushing up (or did?) the `solr.cmd` 
change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to