epugh commented on code in PR #5333:
URL: https://github.com/apache/solr/pull/5333#discussion_r4580333646


##########
solr/bin/solr:
##########
@@ -962,16 +962,27 @@ fi
 if [[ "$SCRIPT_CMD" == "stop" ]]; then
   if $stop_all; then
     none_stopped=true
-    # Read from a process substitution, not a pipeline, so none_stopped 
survives the loop
-    while read -r PIDF; do
+    other_pidfiles=()
+    zookeeper_pidfiles=()
+    while IFS= read -r PIDF; do
+      NEXT_PID=$(cat "$PIDF")
+      if ps -ww -o args= -p "$NEXT_PID" | grep -q -- 
'-Dsolr.zookeeper.server.enabled=true'; then

Review Comment:
   i had a different one hear where it ran `ps` once, but then there was a 
bunch of sed and awk...   I'll look again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to