reiabreu commented on code in PR #9173:
URL: https://github.com/apache/storm/pull/9173#discussion_r4303203550
##########
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/trident/HdfsState.java:
##########
@@ -346,7 +346,14 @@ public HdfsFileOptions withBufferSize(int sizeInBytes) {
return this;
}
- @Deprecated
+ /**
+ * Adds a rotation action.
+ *
+ * @param action the rotation action to add
+ * @return {@link HdfsFileOptions}
+ * @deprecated This method is marked for removal.
+ */
+ @Deprecated(since = "2.0.0", forRemoval = true)
Review Comment:
`addRotationAction` has been deprecated since 2015 (commit 5631b9d47,
"Support for exactly once semantics in HdfsState", first released in 1.0.0),
not since 2.0.0. It is the only `@Deprecated` in this file.
```suggestion
@Deprecated(since = "1.0.0", forRemoval = true)
```
##########
storm-client/src/jvm/org/apache/storm/drpc/LinearDRPCTopologyBuilder.java:
##########
@@ -63,7 +63,15 @@ public LinearDRPCInputDeclarer addBolt(IBatchBolt bolt) {
return addBolt(bolt, 1);
}
- @Deprecated
+ /**
+ * Adds a bolt to the topology.
+ *
+ * @param bolt the rich bolt to add
+ * @param parallelism parallelism hint
+ * @return input declarer
+ * @deprecated please use {@link #addBolt(IBatchBolt, Number)} or {@link
#addBolt(IBasicBolt, Number)} instead.
+ */
+ @Deprecated(since = "2.0.0", forRemoval = true)
Review Comment:
`addBolt(IRichBolt, Number)` was deprecated in January 2012 (commit
6bcd3bb4c, "deprecate richbolt interface for drpc"), long before 2.0.0. In
2.0.0 only the class-level deprecation was removed (commit 97c1d10ca). The
release that first contained it can't be determined from the history available,
so it's better to leave `since` out than to state a wrong version:
```suggestion
@Deprecated(forRemoval = true)
```
##########
storm-client/src/jvm/org/apache/storm/drpc/LinearDRPCTopologyBuilder.java:
##########
@@ -73,7 +81,14 @@ public LinearDRPCInputDeclarer addBolt(IRichBolt bolt,
Number parallelism) {
return new InputDeclarerImpl(component);
}
- @Deprecated
+ /**
+ * Adds a bolt to the topology.
+ *
+ * @param bolt the rich bolt to add
+ * @return input declarer
+ * @deprecated please use {@link #addBolt(IBatchBolt)} or {@link
#addBolt(IBasicBolt)} instead.
+ */
+ @Deprecated(since = "2.0.0", forRemoval = true)
Review Comment:
Same for `addBolt(IRichBolt)`: it belongs to the same 2012 deprecation.
```suggestion
@Deprecated(forRemoval = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
