Mohit20057 commented on PR #9173: URL: https://github.com/apache/storm/pull/9173#issuecomment-6401005019
@rzo1 Thanks for the review! I have updated the branch to address all the points: 1. **`HdfsFileOptions#addRotationAction`**: Updated to `@Deprecated(since = "1.0.0", forRemoval = false)` with updated Javadoc noting it is retained for backwards compatibility. 2. **`BaseResourceAwareStrategy.NodeSortType` (`GENERIC_RAS`, `DEFAULT_RAS`)**: Changed to `forRemoval = false`. Also annotated `GenericResourceAwareStrategyOld` and `DefaultResourceAwareStrategyOld` with `@Deprecated(since = "2.3.0", forRemoval = false)` directing users to the current non-"Old" strategies. 3. **`Flux.java` & `NodeSorter*` private members**: Removed `(since = "...", forRemoval = true)` on private fields and private methods so they remain standard `@Deprecated` without affecting public API contracts. 4. Rebased onto latest `master`, resolved merge conflicts in `StormMetricRegistry` and `StormReporter`, and verified test compilation with JDK 23 (0 Checkstyle violations). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
