rzo1 commented on PR #9173: URL: https://github.com/apache/storm/pull/9173#issuecomment-6387519031
Thanks, the `since` values I checked all match the tags now. Two decisions I'd question: 1. `HdfsFileOptions.addRotationAction` is marked `forRemoval=true` without a replacement, while the feature still works and the `SequenceFileOptions` variant is not deprecated and is documented in `storm-hdfs.md`. Maybe `forRemoval=false`, or a short rationale? 2. `NodeSortType.GENERIC_RAS`/`DEFAULT_RAS` are marked for removal, but the public `*ResourceAwareStrategyOld` classes that use them are not deprecated. Should those be deprecated too? The description still mentions the old `since` values and `getStatus`, which no longer match the diff. Nit: `forRemoval` on private members (e.g. in `Flux`, `NodeSorter`) has no effect for API users. The conflicts are from #9184 and look trivial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
