RocMarshal commented on code in PR #3295:
URL:
https://github.com/apache/incubator-streampark/pull/3295#discussion_r1375412278
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/YarnQueueController.java:
##########
@@ -55,7 +55,7 @@ public class YarnQueueController {
@ApiAccess
@PostMapping("list")
public RestResponse list(RestRequest restRequest, YarnQueue yarnQueue) {
- IPage<YarnQueue> queuePage = yarnQueueService.findYarnQueues(yarnQueue,
restRequest);
+ IPage<YarnQueue> queuePage = yarnQueueService.page(yarnQueue, restRequest);
Review Comment:
~
##########
streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/service/YarnQueueServiceTest.java:
##########
@@ -97,7 +97,7 @@ void testFindYarnQueues() {
// Test for 1st page, size = 2, order by create time with queue_label
queryParams.setQueueLabel("q3");
IPage<YarnQueue> yarnQueuesWithQueueLabelLikeQuery =
- yarnQueueService.findYarnQueues(queryParams, request);
+ yarnQueueService.page(queryParams, request);
Review Comment:
~
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/VariableController.java:
##########
@@ -91,7 +91,7 @@ public RestResponse variableList(@RequestParam Long teamId,
String keyword) {
@PostMapping("dependApps")
@RequiresPermissions("variable:depend_apps")
public RestResponse dependApps(RestRequest restRequest, Variable variable) {
- IPage<Application> dependApps = variableService.dependAppsPage(variable,
restRequest);
+ IPage<Application> dependApps = variableService.pageDependApps(variable,
restRequest);
Review Comment:
how about `getPage`, as mentioned in the guide page, methods name would be
better to start with a `verb`.
##########
streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/service/YarnQueueServiceTest.java:
##########
@@ -87,7 +87,7 @@ void testFindYarnQueues() {
RestRequest request = new RestRequest();
request.setPageSize(2);
request.setPageNum(1);
- IPage<YarnQueue> yarnQueues = yarnQueueService.findYarnQueues(queryParams,
request);
+ IPage<YarnQueue> yarnQueues = yarnQueueService.page(queryParams, request);
Review Comment:
~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
