VampireAchao commented on code in PR #3295:
URL:
https://github.com/apache/incubator-streampark/pull/3295#discussion_r1378518019
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java:
##########
@@ -54,7 +54,7 @@ public interface ProjectService extends IService<Project> {
String getAppConfPath(Long id, String module);
- List<Application> getApplications(Project project);
+ List<Application> list(Project project);
Review Comment:
Refer to the `list()` method in
`com.baomidou.mybatisplus.extension.service.IService`.
When we use `projectService.list()`, the term 'project' is already specified.
Therefore, I believe we can eliminate the redundancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
