caicancai commented on code in PR #3295:
URL:
https://github.com/apache/incubator-streampark/pull/3295#discussion_r1377685088
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java:
##########
@@ -54,7 +54,7 @@ public interface ProjectService extends IService<Project> {
String getAppConfPath(Long id, String module);
- List<Application> getApplications(Project project);
+ List<Application> list(Project project);
- boolean checkExists(Project project);
+ boolean exists(Project project);
Review Comment:
I think checkExists better
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java:
##########
@@ -54,7 +54,7 @@ public interface ProjectService extends IService<Project> {
String getAppConfPath(Long id, String module);
- List<Application> getApplications(Project project);
+ List<Application> list(Project project);
Review Comment:
Just a list?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/YarnQueueService.java:
##########
@@ -27,7 +27,7 @@
public interface YarnQueueService extends IService<YarnQueue> {
- IPage<YarnQueue> findYarnQueues(YarnQueue yarnQueue, RestRequest
restRequest);
+ IPage<YarnQueue> getPage(YarnQueue yarnQueue, RestRequest restRequest);
Review Comment:
getYarnQueuesPage？
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/YarnQueueService.java:
##########
@@ -27,7 +27,7 @@
public interface YarnQueueService extends IService<YarnQueue> {
- IPage<YarnQueue> findYarnQueues(YarnQueue yarnQueue, RestRequest
restRequest);
+ IPage<YarnQueue> getPage(YarnQueue yarnQueue, RestRequest restRequest);
Review Comment:
getYarnQueuesPage？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
