VampireAchao commented on code in PR #3295:
URL:
https://github.com/apache/incubator-streampark/pull/3295#discussion_r1378512133
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java:
##########
@@ -54,7 +54,7 @@ public interface ProjectService extends IService<Project> {
String getAppConfPath(Long id, String module);
- List<Application> getApplications(Project project);
+ List<Application> list(Project project);
- boolean checkExists(Project project);
+ boolean exists(Project project);
Review Comment:
Diff:
```java
void checkExists(Project project) {
if(notExists) {
throw new ProjectNotExistsException();
}
}
```
So:
```java
if (!exists(project)){
throw new ProjectNotExistsException();
}
```
Eq
```java
checkExist(project)
```
Cause "exists" just return boolean type better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
