[ 
https://issues.apache.org/jira/browse/WW-5173?focusedWorklogId=783358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783358
 ]

ASF GitHub Bot logged work on WW-5173:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jun/22 12:20
            Start Date: 21/Jun/22 12:20
    Worklog Time Spent: 10m 
      Work Description: yasserzamani commented on PR #573:
URL: https://github.com/apache/struts/pull/573#issuecomment-1161673971

   Thank you so much @JCgH4164838Gh792C124B5 ! I remember that I also had some 
same difficulties when I was working on #167 . Finally I simply workaround it 
by injecting Container itself and getting required bean instead of injecting 
the bean itself. This isn't a good practice albeit, as Lukasz commented there. 
But this is what I could and able to do that time to make it working. Even with 
a lot debugging.
   
   I'm trying to say that your case is same but more complex, i.e. with 
constructor injection with multiple overloaded constructors. But you were able 
to make it work with no hack. So I think now you know DI better than any of us 
and your changes are best possible solution :)
   
   BTW I found all usages of `@Inject` in constructors parameters by IntelliJ 
IDEA. There are similar cases already implemented in Struts. I assume they're 
working. So the problem is not because of multiple overloaded constructors I 
think.
   
   And could you please explain a bit more about: 
   
   > but the default container instance construction of OgnlUtil still seems to 
use the default implementations
   
   Thanks again!




Issue Time Tracking
-------------------

    Worklog Id:     (was: 783358)
    Time Spent: 0.5h  (was: 20m)

> Implement additional OGNL cache configuration controls
> ------------------------------------------------------
>
>                 Key: WW-5173
>                 URL: https://issues.apache.org/jira/browse/WW-5173
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 6.0.0
>            Reporter: James Chaplin
>            Priority: Minor
>             Fix For: 6.0.1
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> With Struts 2.6, there may be an opportunity to introduce some additional 
> OGNL cache configuration capabilities.  One idea is to provide an cache size 
> control, and a toggle for an LRU cache mode.  These configuration controls 
> could be applied to the expression cache and BeanInfo caches independently.
> The new properties could be optional, with the framework using a standard 
> default cache if the properties are not provided.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to