[
https://issues.apache.org/jira/browse/WW-5173?focusedWorklogId=796901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796901
]
ASF GitHub Bot logged work on WW-5173:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 14:04
Start Date: 01/Aug/22 14:04
Worklog Time Spent: 10m
Work Description: yasserzamani commented on PR #573:
URL: https://github.com/apache/struts/pull/573#issuecomment-1201250072
Thank you @JCgH4164838Gh792C124B5 for testing bits!
> The subtleties for how the naming/associations for the DI configuration
change the behaviour are still a bit mysterious to me
For me too. Today I also tried a lot to make it working as you planned in
previous version. Finally instead of I fixing Struts, it fixed me :)) and
taught me that looks like that when you want to introduce an extension point,
then you shouldn't use a concrete name in `.factory(` and let Struts use its
default name. Otherwise we cannot inject it by a dynamic name. At least I
couldn't. Instead, we should define aliases like what's done in `.alias(`.
At bottom this LGTM and will merge. Just one thing. A few tests which are
from past and not related, are deleted, I think by mistake, right? If so, then
could you revert them. thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 796901)
Time Spent: 2h 10m (was: 2h)
> Implement additional OGNL cache configuration controls
> ------------------------------------------------------
>
> Key: WW-5173
> URL: https://issues.apache.org/jira/browse/WW-5173
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 6.0.0
> Reporter: James Chaplin
> Priority: Minor
> Fix For: 6.0.1
>
> Attachments: S2_StarterApp_1.zip
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> With Struts 2.6, there may be an opportunity to introduce some additional
> OGNL cache configuration capabilities. One idea is to provide an cache size
> control, and a toggle for an LRU cache mode. These configuration controls
> could be applied to the expression cache and BeanInfo caches independently.
> The new properties could be optional, with the framework using a standard
> default cache if the properties are not provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
