[ 
https://issues.apache.org/jira/browse/WW-5173?focusedWorklogId=796592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796592
 ]

ASF GitHub Bot logged work on WW-5173:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jul/22 09:49
            Start Date: 30/Jul/22 09:49
    Worklog Time Spent: 10m 
      Work Description: yasserzamani commented on PR #573:
URL: https://github.com/apache/struts/pull/573#issuecomment-1200126630

   Hi @JCgH4164838Gh792C124B5 sorry I was wrong yesterday. Your sample app 
works, however you need to apply a few fixes on your previous work which I 
introduced by #581 - I learnt them from already working extension points like 
ObjectFactory and ActionFactory.
   
   Please feel free to either merge my PR and rebase your PR based on it, or 
simply redo same fixes on your PR and close my PR please.
   
   Thanks again for your works! and sorry for my late answer.
   
   BTW regarding DTD problem, please apply following patch on your sample app
   ```diff
   Index: src/main/resources/struts.xml
   IDEA additional info:
   Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
   <+>UTF-8
   ===================================================================
   -

Issue Time Tracking
-------------------

    Worklog Id:     (was: 796592)
    Time Spent: 1h 20m  (was: 1h 10m)

> Implement additional OGNL cache configuration controls
> ------------------------------------------------------
>
>                 Key: WW-5173
>                 URL: https://issues.apache.org/jira/browse/WW-5173
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 6.0.0
>            Reporter: James Chaplin
>            Priority: Minor
>             Fix For: 6.0.1
>
>         Attachments: S2_StarterApp_1.zip
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With Struts 2.6, there may be an opportunity to introduce some additional 
> OGNL cache configuration capabilities.  One idea is to provide an cache size 
> control, and a toggle for an LRU cache mode.  These configuration controls 
> could be applied to the expression cache and BeanInfo caches independently.
> The new properties could be optional, with the framework using a standard 
> default cache if the properties are not provided.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to