[
https://issues.apache.org/jira/browse/WW-5173?focusedWorklogId=796718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796718
]
ASF GitHub Bot logged work on WW-5173:
--------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/22 23:12
Start Date: 31/Jul/22 23:12
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on PR #573:
URL: https://github.com/apache/struts/pull/573#issuecomment-1200522088
Hi @yasserzamani . Thank you so much for taking a look, determining what
was failing, and creating PR #581 to show a working solution. 😄 I was not
certain I could do a merge/rebase of your PR correctly, so I just implemented
the equivalent changes in this PR (with some slight modifications).
When built locally, and debugging with the sample app, the custom factory
appears to get instantiated properly, so the changes you proposed/provided look
like they work to me. 👍
The subtleties for how the naming/associations for the DI configuration
change the behaviour are still a bit mysterious to me, but comparing what
worked and did not in this PR history might be helpful to others in the future.
Thank you so much, and let me know if the PR looks OK now. If anyone else
would like to comment, please feel free as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 796718)
Time Spent: 1h 40m (was: 1.5h)
> Implement additional OGNL cache configuration controls
> ------------------------------------------------------
>
> Key: WW-5173
> URL: https://issues.apache.org/jira/browse/WW-5173
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 6.0.0
> Reporter: James Chaplin
> Priority: Minor
> Fix For: 6.0.1
>
> Attachments: S2_StarterApp_1.zip
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> With Struts 2.6, there may be an opportunity to introduce some additional
> OGNL cache configuration capabilities. One idea is to provide an cache size
> control, and a toggle for an LRU cache mode. These configuration controls
> could be applied to the expression cache and BeanInfo caches independently.
> The new properties could be optional, with the framework using a standard
> default cache if the properties are not provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
