[
https://issues.apache.org/jira/browse/WW-5173?focusedWorklogId=802258&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802258
]
ASF GitHub Bot logged work on WW-5173:
--------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/22 16:03
Start Date: 20/Aug/22 16:03
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on PR #573:
URL: https://github.com/apache/struts/pull/573#issuecomment-1221355624
Hi @yasserzamani.
Thanks for the review, and more background on the DI and alias behaviour. 😄
> At bottom this LGTM and will merge. Just one thing. A few tests which are
from past and not related, are deleted, I think by mistake, right? If so, then
could you revert them. thanks!
The `testXXXAlternateConstructor()` tests were intentionally removed with
the recent set of changes, as they no longer made sense to me once the changes
you made to the parameterized `OgnlUtil` constructor were applied to this PR.
Those deleted tests were originally code coverage "duplicate" tests of existing
tests to cover `OgnlUtil(null, null)` calls, but now using null parameters is
invalid and will result in `IllegalArgumentException` , so those tests no
longer seemed to make sense. The general test for `OgnlUtil` with null
parameters should now be covered by
`testDefaultOgnlUtilAlternateConstructorArguments()` , and there are still the
`testXXXAlternateConstructorPopulated()` tests covering non-null parameters.
Please let me know if the above makes sense, and if you agree the test
changes are valid ?
If not, I can restore the deleted tests and make changes to pattern them
like `testDefaultOgnlUtilAlternateConstructorArguments()`. Please let me know
what you think.
Issue Time Tracking
-------------------
Worklog Id: (was: 802258)
Time Spent: 2.5h (was: 2h 20m)
> Implement additional OGNL cache configuration controls
> ------------------------------------------------------
>
> Key: WW-5173
> URL: https://issues.apache.org/jira/browse/WW-5173
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 6.0.0
> Reporter: James Chaplin
> Priority: Minor
> Fix For: 6.1.0
>
> Attachments: S2_StarterApp_1.zip
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> With Struts 2.6, there may be an opportunity to introduce some additional
> OGNL cache configuration capabilities. One idea is to provide an cache size
> control, and a toggle for an LRU cache mode. These configuration controls
> could be applied to the expression cache and BeanInfo caches independently.
> The new properties could be optional, with the framework using a standard
> default cache if the properties are not provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
