Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/381#discussion_r24560513
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
---
@@ -211,12 +169,16 @@ protected void loadRightToHashTable() throws
IOException {
}
List<Tuple> newValue = tupleSlots.get(keyTuple);
- if (newValue != null) {
- newValue.add(tuple);
- } else {
- newValue = new ArrayList<Tuple>();
- newValue.add(tuple);
- tupleSlots.put(keyTuple, newValue);
+ try {
+ if (newValue != null) {
+ newValue.add(tuple.clone());
--- End diff --
I found that this cloning increases the memory space usage significantly,
which causes frequent GC.
Currently, there is a problem of that the reference of the ```tuple```
value is not changed.
That is, the underlying operator returns the ```tuple``` with the same
reference but the different contents.
I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
