Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/381#discussion_r24727521
  
    --- Diff: 
tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
 ---
    @@ -358,7 +353,21 @@ public LogicalNode visitJoin(FilterPushDownContext 
context, LogicalPlan plan, Lo
           context.pushingDownFilters.removeAll(matched);
         }
     
    -    
context.pushingDownFilters.addAll(outerJoinFilterEvalsExcludePredication);
    +    matched.clear();
    --- End diff --
    
    Could add some brief comment about the purpose of the following block? It 
would be helpful for other code readers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to