Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/381#discussion_r24726468
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BNLJoinExec.java
---
@@ -190,15 +152,12 @@ public Tuple next() throws IOException {
}
}
- frameTuple.set(leftTuple, rightIterator.next());
- if (hasJoinQual) {
- if (joinQual.eval(inSchema, frameTuple).isTrue()) {
- projector.eval(frameTuple, outputTuple);
- return outputTuple;
+ updateFrameTuple(leftTuple, rightIterator.next());
+
+ if (evalQual()) {
--- End diff --
Except for BNLJoinExec, all join operators (hash, and merge joins) must
have join conditions.
BNLJoinExec can be used for cross join, meaning that there is no join
condition. Nevertheless, it can have join filter as follows:
```
SELECT x, y, z FROM A, B WHERE concat (x,y) = 'keyword'
```
```concat (x,y) = 'keyword'``` will be play a join filter in BNL join
operator. So, we need to consider join condition and filter separately in
BNLJoinExec.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
