Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/381#issuecomment-74443711
The patch looks good to me. The changes clean up join operators and and
join plans. This separation between join filter and join condition would make
more opportunities to clean up other join related codes later. I leave some
comments. After your answer, I'll finish the review.
In addition, I think that FilterPushDownRule::visitJoin has a long single
method. We need to clean up and refactor the method into several small
well-defined methods. For it, we may need another jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
