[ 
https://issues.apache.org/jira/browse/TAJO-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368746#comment-14368746
 ] 

Tajo QA commented on TAJO-1420:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12705535/TAJO-1420.patch
  against master revision release-0.9.0-rc0-208-g725448c.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to cause Findbugs 
(version 2.0.3) to fail.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-algebra tajo-core tajo-plan.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/622//testReport/
Findbugs results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/622//findbugsResult
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/622//console

This message is automatically generated.

> Support GROUPING SET syntax
> ---------------------------
>
>                 Key: TAJO-1420
>                 URL: https://issues.apache.org/jira/browse/TAJO-1420
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: parser
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1420.patch
>
>
> This issue is about SQL parsing only. As of Tajo 0.10.0,
> {code:sql}
> default> create table t(a int, b int);
> OK
> default> select * from t group by cube(a,b);
> ERROR: Cube is not supported yet
> default> select * from t group by rollup(a,b);
> ERROR: Rollup is not supported yet
> default> select * from t group by grouping set(a,b);
> ERROR: syntax error at or near 'grouping'
> {code}
> The last error should be like the following.
> {code:sql}
> default> select * from t group by grouping set(a,b);
> ERROR: GroupingSet is not supported yet
> {code}
> As you know, 
> {code:sql}
> GROUP BY a, b, c WITH CUBE
> {code}
> is equivalent to
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (b, c), (a, c), (a), (b), 
> (c), ( ))
> {code}
> And, 
> {code:sql}
> GROUP BY a, b, c, WITH ROLLUP
> {code}
> is equivalent to 
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (a), ( ))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to