[ 
https://issues.apache.org/jira/browse/TAJO-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395733#comment-14395733
 ] 

ASF GitHub Bot commented on TAJO-1420:
--------------------------------------

Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/tajo/pull/439#issuecomment-89582611
  
    I see. I agree with you on the purpose of Jira as a architectural design 
discussion tools before implementation. For this trivial issue, it was not so 
important. But if we move on Grouping Set issue, we need more discussion. Also, 
now I understand your original recommendation to implement the execution logic 
of the grouping set first. I will study the links (which you given) and read 
related projects/materials and update this issue for discussion before 
implementation. Thank you, @jihoonson. Always. :) 


> Support GROUPING SET syntax
> ---------------------------
>
>                 Key: TAJO-1420
>                 URL: https://issues.apache.org/jira/browse/TAJO-1420
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: parser
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1420.patch
>
>
> This issue is about SQL parsing only. As of Tajo 0.10.0,
> {code:sql}
> default> create table t(a int, b int);
> OK
> default> select * from t group by cube(a,b);
> ERROR: Cube is not supported yet
> default> select * from t group by rollup(a,b);
> ERROR: Rollup is not supported yet
> default> select * from t group by grouping set(a,b);
> ERROR: syntax error at or near 'grouping'
> {code}
> The last error should be like the following.
> {code:sql}
> default> select * from t group by grouping set(a,b);
> ERROR: GroupingSet is not supported yet
> {code}
> As you know, 
> {code:sql}
> GROUP BY a, b, c WITH CUBE
> {code}
> is equivalent to
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (b, c), (a, c), (a), (b), 
> (c), ( ))
> {code}
> And, 
> {code:sql}
> GROUP BY a, b, c, WITH ROLLUP
> {code}
> is equivalent to 
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (a), ( ))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to