[ 
https://issues.apache.org/jira/browse/TAJO-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395696#comment-14395696
 ] 

ASF GitHub Bot commented on TAJO-1420:
--------------------------------------

Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/439#issuecomment-89552295
  
    I recommend to implement the execution logic of the grouping set first. 
    
    I know that we support only the syntax of data cube without execution 
logic. However, it is the leavings of the removed data cube operator execution 
logic. 
    Honestly, we had code lines for data cube operator execution, but have 
removed them due to its low performance. However, we didn't removed the syntax 
part because we must support it again. 


> Support GROUPING SET syntax
> ---------------------------
>
>                 Key: TAJO-1420
>                 URL: https://issues.apache.org/jira/browse/TAJO-1420
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: parser
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1420.patch
>
>
> This issue is about SQL parsing only. As of Tajo 0.10.0,
> {code:sql}
> default> create table t(a int, b int);
> OK
> default> select * from t group by cube(a,b);
> ERROR: Cube is not supported yet
> default> select * from t group by rollup(a,b);
> ERROR: Rollup is not supported yet
> default> select * from t group by grouping set(a,b);
> ERROR: syntax error at or near 'grouping'
> {code}
> The last error should be like the following.
> {code:sql}
> default> select * from t group by grouping set(a,b);
> ERROR: GroupingSet is not supported yet
> {code}
> As you know, 
> {code:sql}
> GROUP BY a, b, c WITH CUBE
> {code}
> is equivalent to
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (b, c), (a, c), (a), (b), 
> (c), ( ))
> {code}
> And, 
> {code:sql}
> GROUP BY a, b, c, WITH ROLLUP
> {code}
> is equivalent to 
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (a), ( ))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to