[
https://issues.apache.org/jira/browse/TAJO-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395701#comment-14395701
]
ASF GitHub Bot commented on TAJO-1420:
--------------------------------------
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/tajo/pull/439#issuecomment-89555663
Thank you for telling me the behind story, @jihoonson . I didn't know the
cause of inconsistency before.
By the way, in a social coding space, I think my small codes can be
stepping stones to help someone who starts faster than me. So, we should break
our big problems into small problems as possible as we can. Don't you think so?
:)
IMO, if you open your code in your github and everyone can see your
low-performance code, Tajo will get the better performance faster. Otherwise,
you will see my or others' similar low-performance code again because nobody
knows the performance cut-line. It would be a little bit waste of community
efforts. What about making your code open, @jihoonson ?
In any way, I respect Tajo community's policy. I will keep this pull
request and move on execution logic after finishing current ORC format issue.
Warmly,
Dongjoon.
> Support GROUPING SET syntax
> ---------------------------
>
> Key: TAJO-1420
> URL: https://issues.apache.org/jira/browse/TAJO-1420
> Project: Tajo
> Issue Type: Sub-task
> Components: parser
> Affects Versions: 0.10.0
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Minor
> Fix For: 0.10.1
>
> Attachments: TAJO-1420.patch
>
>
> This issue is about SQL parsing only. As of Tajo 0.10.0,
> {code:sql}
> default> create table t(a int, b int);
> OK
> default> select * from t group by cube(a,b);
> ERROR: Cube is not supported yet
> default> select * from t group by rollup(a,b);
> ERROR: Rollup is not supported yet
> default> select * from t group by grouping set(a,b);
> ERROR: syntax error at or near 'grouping'
> {code}
> The last error should be like the following.
> {code:sql}
> default> select * from t group by grouping set(a,b);
> ERROR: GroupingSet is not supported yet
> {code}
> As you know,
> {code:sql}
> GROUP BY a, b, c WITH CUBE
> {code}
> is equivalent to
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (b, c), (a, c), (a), (b),
> (c), ( ))
> {code}
> And,
> {code:sql}
> GROUP BY a, b, c, WITH ROLLUP
> {code}
> is equivalent to
> {code:sql}
> GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (a), ( ))
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
