[
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383251#comment-14383251
]
ASF GitHub Bot commented on TAJO-1350:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/384#issuecomment-86791563
Thanks for all your valuable reviews. I'll commit shortly.
@sirpkt, I also think that the selection should be pushed down to after the
first join. This will improve the query performance.
To resolve this problem, I think that we need to add another filter
pushdown optimization phase after join ordering. Please note that the filter
pushdown phase is currently called only before join ordering.
After join ordering, the best position of each predicate will be
differernt. So, it seems the problem of our query optimization rather than just
a problem of filter pushdown. I'll create another issue.
> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
> Key: TAJO-1350
> URL: https://issues.apache.org/jira/browse/TAJO-1350
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Jihoon Son
> Fix For: 0.11.0
>
> Attachments: TAJO-1350.patch, TAJO-1350_2.patch, TAJO-1350_3.patch,
> TAJO-1350_4.patch
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles
> various cases in a single method. We need to refactor this method into
> several small and well-defined methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
