[
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381594#comment-14381594
]
ASF GitHub Bot commented on TAJO-1350:
--------------------------------------
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/384#discussion_r27196435
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
---
@@ -1972,6 +1976,52 @@ public static boolean
checkIfBeEvaluatedAtGroupBy(EvalNode evalNode, GroupbyNode
return true;
}
+ public static boolean isEvaluatableJoinQual(QueryBlock block, EvalNode
evalNode, JoinNode node,
+ boolean isOnPredicate,
boolean isTopMostJoin) {
+
+ if (checkIfBeEvaluatedAtJoin(block, evalNode, node, isTopMostJoin)) {
+
+ if (isNonEquiThetaJoinQual(block, node, evalNode)) {
+ return false;
+ }
+
+ if (PlannerUtil.isOuterJoin(node.getJoinType())) {
+ /*
--- End diff --
It seems to exceed 120 columns.
> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
> Key: TAJO-1350
> URL: https://issues.apache.org/jira/browse/TAJO-1350
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Jihoon Son
> Fix For: 0.11.0
>
> Attachments: TAJO-1350.patch, TAJO-1350_2.patch, TAJO-1350_3.patch,
> TAJO-1350_4.patch
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles
> various cases in a single method. We need to refactor this method into
> several small and well-defined methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
