[ 
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381451#comment-14381451
 ] 

ASF GitHub Bot commented on TAJO-1350:
--------------------------------------

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/384#issuecomment-86359111
  
    @jihoonson 
    
    It seems that there was some problems on my laptop. I can't reproduce it 
again. :-)
    And I'm still reviewing. I'll finish soon.


> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
>                 Key: TAJO-1350
>                 URL: https://issues.apache.org/jira/browse/TAJO-1350
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Jihoon Son
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1350.patch, TAJO-1350_2.patch, TAJO-1350_3.patch, 
> TAJO-1350_4.patch
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles 
> various cases in a single method. We need to refactor this method into 
> several small and well-defined methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to