[
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381395#comment-14381395
]
ASF GitHub Bot commented on TAJO-1350:
--------------------------------------
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/384#issuecomment-86348625
@jihoonson
Thanks for your contribution.
But I failed to run an unit test for TestNetTypes as following:
```
-------------------------------------------------------------------------------
Test set: org.apache.tajo.engine.query.TestNetTypes
-------------------------------------------------------------------------------
Tests run: 6, Failures: 6, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec
<<< FAILURE! - in org.apache.tajo.engine.query.TestNetTypes
testSort2(org.apache.tajo.engine.query.TestNetTypes) Time elapsed: 0 sec
<<< FAILURE!
java.lang.AssertionError:
file:/Users/blrunner/Source/tajo/tajo-core/target/test-classes/dataset/TestNetTypes/table1
existence check
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.tajo.QueryTestCaseBase.getDataSetFile(QueryTestCaseBase.java:605)
at
org.apache.tajo.QueryTestCaseBase.executeDDL(QueryTestCaseBase.java:656)
at
org.apache.tajo.QueryTestCaseBase.executeDDL(QueryTestCaseBase.java:643)
at
org.apache.tajo.engine.query.TestNetTypes.setUp(TestNetTypes.java:32)
```
The strange thing is that it only is reproduced on console. I found that it
had run successfully with IDE.
Could you check this problem on your development environment?
> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
> Key: TAJO-1350
> URL: https://issues.apache.org/jira/browse/TAJO-1350
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Jihoon Son
> Fix For: 0.11.0
>
> Attachments: TAJO-1350.patch, TAJO-1350_2.patch, TAJO-1350_3.patch,
> TAJO-1350_4.patch
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles
> various cases in a single method. We need to refactor this method into
> several small and well-defined methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
