[
https://issues.apache.org/jira/browse/TAJO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085066#comment-15085066
]
ASF GitHub Bot commented on TAJO-1971:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/890#discussion_r48931657
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyHashAggregationExec.java
---
@@ -366,8 +365,8 @@ public HashAggregator(GroupbyNode groupbyNode, Schema
schema) throws IOException
Column[] keyColumns = groupbyNode.getGroupingColumns();
Column col;
- for (int idx = 0; idx < keyColumns.length; idx++) {
- col = keyColumns[idx];
+ for (Column keyColumn : keyColumns) {
+ col = keyColumn;
--- End diff --
```col``` is redundant.
> Replace 'for' loop with 'foreach'
> ---------------------------------
>
> Key: TAJO-1971
> URL: https://issues.apache.org/jira/browse/TAJO-1971
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Trivial
> Labels: newbie
>
> Reports for loops which iterate over collections or arrays, and can be
> replaced with the foreach iteration syntax, available in Java 5 and newer, to
> get the improvement of readability and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
