[
https://issues.apache.org/jira/browse/TAJO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055293#comment-15055293
]
ASF GitHub Bot commented on TAJO-1971:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/890#discussion_r47456865
--- Diff:
tajo-common/src/test/java/org/apache/tajo/datum/TestIntervalDatum.java ---
@@ -122,8 +122,8 @@ public final void testOperation() throws Exception {
// date '2001-10-01' - integer '7' ==> date '2001-09-24'
datum = DatumFactory.createDate(2001, 10, 1);
- for (int i = 0; i < datums.length; i++) {
- Datum result2 = datum.minus(datums[i]);
+ for (Datum datum1 : datums) {
--- End diff --
Well, this is valid but it looks not a good convention. How about to change
```eachDatum```?
> Replace 'for' loop with 'foreach'
> ---------------------------------
>
> Key: TAJO-1971
> URL: https://issues.apache.org/jira/browse/TAJO-1971
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Trivial
> Labels: newbie
>
> Reports for loops which iterate over collections or arrays, and can be
> replaced with the foreach iteration syntax, available in Java 5 and newer, to
> get the improvement of readability and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
