[
https://issues.apache.org/jira/browse/TAJO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055298#comment-15055298
]
ASF GitHub Bot commented on TAJO-1971:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/890#discussion_r47456988
--- Diff:
tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/commons/AnalyzerAdapter.java
---
@@ -177,33 +177,32 @@ protected AnalyzerAdapter(final int api, final String
owner,
}
}
Type[] types = Type.getArgumentTypes(desc);
- for (int i = 0; i < types.length; ++i) {
- Type type = types[i];
+ for (Type type : types) {
switch (type.getSort()) {
- case Type.BOOLEAN:
- case Type.CHAR:
- case Type.BYTE:
- case Type.SHORT:
- case Type.INT:
- locals.add(Opcodes.INTEGER);
- break;
- case Type.FLOAT:
- locals.add(Opcodes.FLOAT);
- break;
- case Type.LONG:
- locals.add(Opcodes.LONG);
- locals.add(Opcodes.TOP);
- break;
- case Type.DOUBLE:
- locals.add(Opcodes.DOUBLE);
- locals.add(Opcodes.TOP);
- break;
- case Type.ARRAY:
- locals.add(types[i].getDescriptor());
- break;
- // case Type.OBJECT:
- default:
- locals.add(types[i].getInternalName());
+ case Type.BOOLEAN:
--- End diff --
Please remove unnecessary change.
> Replace 'for' loop with 'foreach'
> ---------------------------------
>
> Key: TAJO-1971
> URL: https://issues.apache.org/jira/browse/TAJO-1971
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Trivial
> Labels: newbie
>
> Reports for loops which iterate over collections or arrays, and can be
> replaced with the foreach iteration syntax, available in Java 5 and newer, to
> get the improvement of readability and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
